Update ConfigDump documentation.#16491
Merged
antoniovicente merged 4 commits intoenvoyproxy:mainfrom May 20, 2021
Merged
Conversation
Signed-off-by: Paul Gallagher <pgal@google.com>
| // * *listeners*: :ref:`ListenersConfigDump <envoy_v3_api_msg_admin.v3.ListenersConfigDump>` | ||
| // * *scoped_routes*: :ref:`ScopedRoutesConfigDump <envoy_v3_api_msg_admin.v3.ScopedRoutesConfigDump>` | ||
| // * *routes*: :ref:`RoutesConfigDump <envoy_v3_api_msg_admin.v3.RoutesConfigDump>` | ||
| // * *secrets*: :ref:`SecretsConfigDump <envoy_v3_api_msg_admin.v3.SecretsConfigDump>` |
Contributor
There was a problem hiding this comment.
Do you happen to know what PRs added support for these additional types?
Contributor
Author
Contributor
|
CI found some issues with generation of shadow protos from the proto you edited. Could you run /wait |
Signed-off-by: Paul Gallagher <pgal@google.com>
Signed-off-by: Paul Gallagher <pgal@google.com>
lizan
approved these changes
May 18, 2021
Member
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
|
Please merge upstream/main. The QUIC coverage failure is deterministic so merging main is needed to fix the CI failure. |
antoniovicente
approved these changes
May 19, 2021
Signed-off-by: Paul Gallagher <pgal@google.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Paul Gallagher <pgal@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Gallagher pgal@google.com
Commit Message: update ConfigDump documentation
Additional Description: ScopedRoutesConfigDump and SecretsConfigDump were missing.
Risk Level: Low
Testing: NA
Docs Changes: Yes
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]